Bug 6685 - [review] Sync Debian packaging from v3.3.2-2 to trunk
Summary: [review] Sync Debian packaging from v3.3.2-2 to trunk
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Packaging: debian (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: All All
: P2 normal
Target Milestone: Undefined
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 01:42 UTC by Darxus
Modified: 2011-10-28 15:17 UTC (History)
2 users (show)


Attachment Type Modified Status Actions Submitter/CLA Status
patch patch None Darxus [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darxus 2011-10-28 01:42:19 UTC 
Created attachment 4989 [details]
patch

From the Debian changelog:

spamassassin (3.3.2-2) unstable; urgency=low

  * Remove dependencies on libdigest-sha1-perl, since it's being 
    removed from Debian. (Closes: #629612)

 -- Noah Meyerhans <noahm@debian.org>  Thu, 18 Aug 2011 17:07:05 -0700


Very minor.  Done the same as bug 6647 and bug 6593.  Thoroughly documented at http://wiki.apache.org/spamassassin/SyncDebianPackaging

Not tested, just as before, because of minimal possibility of breakage and significantly increased ease of testing after commit.

All modified files:
+++ debian/control
+++ debian/README.source
+++ debian/changelog

Current delta from Debian is the same as last time, removing two patches because they have already been applied to trunk:  85_disable_SSLv2 and 50_sa-learn_fix_empty_list_handling.  Exact same packaging is used by Ubuntu.

Shouldn't need any votes, just a commit, since I don't have the access.
Comment 1 Kevin A. McGrail 2011-10-28 14:28:10 UTC 
I don't see how the README.source is relevant to the SA project.  

Otherwise committed:

svn commit -m 'Debian build file changes per bug 6685' 
Sending        debian/changelog
Sending        debian/control
Transmitting file data ..
Committed revision 1190353.
Comment 2 Darxus 2011-10-28 14:32:36 UTC 
(In reply to comment #1)
> I don't see how the README.source is relevant to the SA project.  

It's not.  I just don't think it's worth the additional work to maintain the difference from the debian packaging.  But no objection to you leaving it out.  Just seems silly.

> Otherwise committed:

Thanks, rebuilding.
Comment 3 Kevin A. McGrail 2011-10-28 14:45:11 UTC 
(In reply to comment #2)
> (In reply to comment #1)
> > I don't see how the README.source is relevant to the SA project.  
> 
> It's not.  I just don't think it's worth the additional work to maintain the
> difference from the debian packaging.  But no objection to you leaving it out. 
> Just seems silly.
 
It's a note from the DEBIAN packagers explaining their differences downstream.  To me it seems silly to include it upstream.
Comment 4 Darxus 2011-10-28 15:03:59 UTC 
Yes, but this patch was created by a very simple process of deleting the existing /debian/ directory in trunk, copying over the contents of the spamassassin_*.debian.tar.gz from Debian, and doing a diff (after deleting the two no-longer necessary patches).  I don't see how it's worth deleting that comment every time from now on.  It's just extra work maintaining a delta between the latest packaging info from Debian, and a slightly older version of the same thing from the same source, that affects nothing.

(Synced update to launchpad, queued build.)
Comment 5 Kevin A. McGrail 2011-10-28 15:17:56 UTC 
(In reply to comment #4)
> Yes, but this patch was created by a very simple process of deleting the
> existing /debian/ directory in trunk, copying over the contents of the
> spamassassin_*.debian.tar.gz from Debian, and doing a diff (after deleting the
> two no-longer necessary patches).  I don't see how it's worth deleting that
> comment every time from now on.  It's just extra work maintaining a delta
> between the latest packaging info from Debian, and a slightly older version of
> the same thing from the same source, that affects nothing.
> 
> (Synced update to launchpad, queued build.)

We'll agree to disagree ;-)