[SPARK-9886] Validate usages of Runtime.getRuntime.addShutdownHook

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0, 2.0.0
• Component/s: Spark Core
• Target Version/s: 1.6.1, 2.0.0
• Assignee: Naveen Kumar Minchu
• Reporter: Michel Lemay
• Created: 12/Aug/15 18:01
• Updated: 24/Dec/15 13:21
• Resolved: 16/Dec/15 02:25

Description

While refactoring calls to Utils.addShutdownHook to spark ShutdownHookManager in PR #8109, I've seen instances of calls to Runtime.getRuntime.addShutdownHook:

org\apache\spark\deploy\ExternalShuffleService.scala:126
org\apache\spark\deploy\mesos\MesosClusterDispatcher.scala:113
org\apache\spark\storage\ExternalBlockStore.scala:181

Comment from @vanzin:
"From a quick look, it seems that at least the one in ExternalBlockStore should be changed; the other two seem to be separate processes (i.e. they are not part of a Spark application) so that's questionable. But I'd say leave it for a different change (maybe file a separate bug so it doesn't fall through the cracks)."

Issue Links

• links to: Pull Request on ExternalBlockStore.scala