[HTTPCLIENT-1098] Populating exception message with InetSocketAddress.getHostName() can take a long time

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.1
• Fix Version/s: 4.1.2
• Component/s: HttpClient (classic)
• Labels: ConnectTimeoutException InetSocketAddress getHostName
• Assignee: Unassigned
• Reporter: Thomas Boettcher
• Created: 06/Jun/11 16:53
• Updated: 20/Sep/16 19:30
• Resolved: 07/Jun/11 08:55

Description

In the PlainSocketFactory class, when a SocketTimeoutException occurs a call is made to InetSocketAddress.getHostName() when generating the exception message. Unfortunately, this call can take a long time. In my case, the address I am specifying is an IP address, which InetSocketAddress attempts to perform a reverse-lookup on to determine the hostname; however, since the address does not have a hostname assigned to it, the operation takes a long time to return.

I'm attaching a patch for trunk with my proposed fix. Viewing the source history, it looks like the code used to have the behavior I'm proposing, but it was changed in revision 1070943. Based on the source commits and linked issues, I cannot determine a specific reason for the change. If there is a reason the code needs to be the way it is, then I apologize for inconvenience I have caused.