[HDFS-16681] Do not pass GCC flags for MSVC in libhdfspp

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: libhdfs++
• Labels: libhdfscpp pull-request-available

Environment

Windows 10

Language

CMake

• Assignee: Gautham Banasandra
• Reporter: Gautham Banasandra
• Due: 30/Jul/22
• Created: 23/Jul/22 18:31
• Updated: 25/Jul/22 17:26
• Resolved: 25/Jul/22 17:26

Description

The tests in HDFS native client uses the -Wno-missing-field-initializers flag to ignore warnings about uninitialized members - https://github.com/apache/hadoop/blob/8f83d9f56d775c73af6e3fa1d6a9aa3e64eebc37/hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/CMakeLists.txt#L27-L28

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-missing-field-initializers")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wno-missing-field-initializers")

This leads to the following error on Visual C++.

[exec] "E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\ALL_BUILD.vcxproj" (default target) (1) ->
[exec] "E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\x-platform\x_platform_dirent_test_obj.vcxproj" (default target) (24) ->
[exec]   cl : command line error D8021: invalid numeric argument '/Wno-missing-field-initializers' [E:\hadoop-hdfs-project\hadoop-hdfs-native-client\target\native\main\native\libhdfspp\tests\x-platform\x_platform_dirent_test_obj.vcxproj]

Thus, we need to pass this flag only when the compiler isn't Visual C++.

Issue Links

• is a child of: HADOOP-17193 Compile Hadoop on Windows natively
• links to: GitHub Pull Request #4615