[GROOVY-9081] CLONE - Fix warning "An illegal reflective access operation has occurred"

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.4.11, 2.4.15
• Fix Version/s: 3.0.0-beta-1
• Component/s: groovy-jdk

Environment

>gradle --version
Gradle 4.2
Build time: 2017-09-20 14:48:23 UTC
Revision: 5ba503cc17748671c83ce35d7da1cffd6e24dfbd

Groovy: 2.4.11
Ant: Apache Ant(TM) version 1.9.6 compiled on June 29 2015
JVM: 9 (Oracle Corporation 9+181)
OS: Windows 10 10.0 amd64

• Assignee: Daniel Sun
• Reporter: Benjamin Roedell
• Created: 15/Apr/19 06:19
• Updated: 22/Jul/23 15:04
• Resolved: 06/May/19 12:35

Description

This cloned issue is to cover the rest part of GROOVY-8339.

1) Sub-class derives the public members from package-private class, but invoke the members on the sub class instances, e.g.

1.0) Non-category
https://github.com/apache/groovy/blob/master/subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/Groovysh.groovy#L532
1.1) Category
https://github.com/apache/groovy/blob/master/src/spec/test/TraitsSpecificationTest.groovy#L835

3) Access public members of private class, e.g.

https://github.com/apache/groovy/blob/master/subprojects/groovy-console/src/main/groovy/groovy/inspect/swingui/ScriptToTreeNodeAdapter.groovy#L235
java.util.Collections.UnmodifiableMap::toString
We should try to find the overrided member of its base class and access(virtual invocation will happen eventually)

4) Access public members of package-private class, e.g.

https://github.com/apache/groovy/blob/master/src/spec/test/gdk/WorkingWithIOSpecTest.groovy#L355
java.lang.ProcessImpl::waitFor
We should try to find the overrided member of its base class and access(virtual invocation will happen eventually)

5) Favor the method with more accurate parameter type even if it is not visible, e.g. EnumMap::equals(EnumMap<?,?>)

https://github.com/apache/groovy/blob/master/subprojects/parser-antlr4/src/test/groovy/org/apache/groovy/parser/antlr4/util/ASTComparatorCategory.groovy#L271
When comparing two ClassNode instances, ClassNode.transformInstances will be compared, their type is EnumMap

7) Access non-visible constructor when as type, e.g.

https://github.com/apache/groovy/blob/master/src/test/groovy/lang/MapOfClosureTest.groovy#L57
The constructor of TimerTask is protected

 

Issue Links

• is a clone of: GROOVY-8339 Fix warning "An illegal reflective access operation has occurred"
• is cloned by: GROOVY-9103 CLONE - CLONE - Fix warning "An illegal reflective access operation has occurred"
• relates to: GROOVY-10931 Remove $getLookup method generation (Groovy 4+)
• links to: GitHub Pull Request #920