[GROOVY-4831] New line character is not escaped in attribute when using MarkupBuilder

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.8.1
• Component/s: XML Processing
• Assignee: Paul King
• Reporter: Jakub Neubauer
• Created: 18/May/11 06:33
• Updated: 21/Jul/11 19:06
• Resolved: 23/May/11 17:12

Description

For example:

import groovy.xml.*
def xml = new MarkupBuilder()
xml.test(a:"hello\nworld"){}

produces output:

<test a='hello
world' />

But xml specification says that when parsing, new lines in attribute value should be converted to single space. So they are not preserved.

I suggest this new method implementation (sorry that I don't provide real .patch):

    private String checkForReplacement(boolean isAttrValue, char ch) {
        switch (ch) {
            case '&':
                return "&";
            case '<':
                return "&lt;";
            case '>':
                return "&gt;";
            case '"':
                // The double quote is only escaped if the value is for
                // an attribute and the builder is configured to output
                // attribute values inside double quotes.
                if (isAttrValue && useDoubleQuotes) return "&quot;";
                break;
            case '\'':
                // The apostrophe is only escaped if the value is for an
                // attribute, as opposed to element content, and if the
                // builder is configured to surround attribute values with
                // single quotes.
                if (isAttrValue && !useDoubleQuotes) return "&apos;";
                break;
            case '\n':
                if(isAttrValue) return "&#10;";
            case '\r':
                if(isAttrValue) return "&#13;";
        }
        return null;
    }