[GROOVY-10696] The DGM removeAll variants which take a closure can be refactored to use removeIf for better efficiency

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.0.5
• Component/s: groovy-jdk
• Assignee: Paul King
• Reporter: Paul King
• Created: 21/Jul/22 01:00
• Updated: 10/Feb/23 21:40
• Resolved: 24/Jul/22 15:07

Description

We'd want all of the normal variations to work unchanged:

def list = ['a', 'b']
list.removeAll { it == 'b' }
assert list == ['a']

def m1 = [a:1, b:2]
m1.removeAll { k,v -> k == 'b' }
assert m1 == [a:1]
def m2 = [a:1, b:2]
m2.removeAll { k,v -> v == 1 }
assert m2 == [b:2]
def m3 = [a:1, b:2]
m3.removeAll { e -> e.key == 'b' }
assert m3 == [a:1]

Issue Links

• links to: GitHub Pull Request #1750