[ZOOKEEPER-1470] zkpython: close() should delete any watcher

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 3.4.3
• Component/s: contrib-bindings
• Labels: memory_leak python
• Assignee: Unassigned
• Reporter: Paul Giannaros
• Created: 20/May/12 17:00
• Updated: 20/May/12 18:31

Description

When calling zookeeper.close(handle), any connection watcher for the handle is not deleted. This is a source of memory leaks for applications that create and close lots of connections. Its damage can be mitigated to some degree by changing the watcher to some function that won't keep references to instances alive before calling close.

The fix is just to add a free_pywatcher(..) call in the close sequence. Alternatively you could allow set_watcher(handle, None) as a way of deleting the watcher, but it's probably best to take care of it on close too.