Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-132

javadoc test does not run if javac test is disabled

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 0.1.0
    • Precommit
    • None

    Description

      I found it trying YETUS-129.00.patch. In this patch, Geode personality turns off only javac test, but javadoc test is also skipped.

      [sekikn@mobile yetus]$ dev-support/test-patch.sh --basedir=../incubator-geode --project=geode --resetrepo 22
      
      (snip)
      
      ============================================================================
      ============================================================================
                       Pre-patch javadoc verification on develop
      ============================================================================
      ============================================================================
      
      
      
      
      ============================================================================
      ============================================================================
                               Applying patch to develop
      ============================================================================
      ============================================================================
      
      
      Applying the patch:
      Tue Oct 27 00:41:29 JST 2015
      cd /Users/sekikn/incubator-geode
      git apply --binary -v --stat --apply -p1 /private/tmp/yetus-27531.22860/patch
      Applied patch gemfire-core/src/main/java/com/gemstone/gemfire/cache/EntryOperation.java cleanly.
      Applied patch gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/EntryOperationImpl.java cleanly.
       .../com/gemstone/gemfire/cache/EntryOperation.java |    2 +-
       .../gemfire/internal/cache/EntryOperationImpl.java |    2 +-
       2 files changed, 2 insertions(+), 2 deletions(-)
      
      (snip)
      
      ============================================================================
      ============================================================================
                              Patch javadoc verification
      ============================================================================
      ============================================================================
      
      
      
      
      ============================================================================
      ============================================================================
                   Determining number of patched ASF License errors
      ============================================================================
      ============================================================================
      
      (snip)
      
      | Vote |      Subsystem |  Runtime   | Comment
      ============================================================================
      |  -1  |       @author  |  0m 00s    | The patch appears to contain 2 @author 
      |      |                |            | tags which the community has agreed to
      |      |                |            | not allow in code contributions.
      |  -1  |    test4tests  |  0m 00s    | The patch doesn't appear to include any 
      |      |                |            | new or modified tests. Please justify why
      |      |                |            | no new tests are needed for this patch.
      |      |                |            | Also please list what manual steps were
      |      |                |            | performed to verify this patch.
      |  +1  |    gradleboot  |  0m 06s    | develop passed 
      |  +1  |    gradleboot  |  0m 04s    | the patch passed 
      |  +1  |    whitespace  |  0m 00s    | Patch has no whitespace issues. 
      |   0  |    asflicense  |  0m 05s    | ASF License check generated no output? 
      |      |                |  0m 32s    | 
      
      
      || Subsystem || Report/Notes ||
      ============================================================================
      | GITHUB PR | https://github.com/apache/incubator-geode/pull/22 |
      | Optional Tests |  asflicense  javadoc  unit  findbugs  |
      | uname | Darwin mobile.local 15.0.0 Darwin Kernel Version 15.0.0: Sat Sep 19 15:53:46 PDT 2015; root:xnu-3247.10.11~1/RELEASE_X86_64 x86_64 |
      | Build tool | gradle |
      | Personality | /Users/sekikn/yetus/dev-support/personality/geode.sh |
      | git revision | develop / 7909836 |
      | findbugs | not supported by the gradle plugin |
      | Powered by | Apache Yetus   http://yetus.apache.org |
      
      
      ============================================================================
      ============================================================================
                                    Finished build.
      ============================================================================
      ============================================================================
      

      This is because ${JDK_DIR_LIST} is initialised in javac_initialize.

      Attachments

        1. YETUS-132.00.patch
          1 kB
          Kengo Seki
        2. YETUS-132.01.patch
          1 kB
          Kengo Seki

        Activity

          People

            sekikn Kengo Seki
            sekikn Kengo Seki
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: