[YARN-5567] Fix script exit code checking in NodeHealthScriptRunner#reportHealthStatus

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0, 3.0.0-alpha1
• Fix Version/s: 3.0.0-alpha1
• Component/s: nodemanager
• Hadoop Flags: Incompatible change, Reviewed

Release Note

Prior to this fix, the NodeManager will ignore any non-zero exit code for any script in the yarn.nodemanager.health-checker.script.path property. With this change, any syntax errors in the health checking script will get flagged as an error in the same fashion (likely exit code 1) that the script detecting a health issue.

• Assignee: Yufei Gu
• Reporter: Yufei Gu
• Created: 26/Aug/16 22:24
• Updated: 26/Feb/20 05:29
• Resolved: 11/Sep/16 13:25

Description

In case of FAILED_WITH_EXIT_CODE, health status should be false.

      case FAILED_WITH_EXIT_CODE:
        setHealthStatus(true, "", now);
        break;

should be

      case FAILED_WITH_EXIT_CODE:
        setHealthStatus(false, "", now);
        break;

Issue Links

• is related to: YARN-6715 Fix documentation about NodeHealthScriptRunner
• relates to: YARN-5595 Update documentation and Javadoc to match change to NodeHealthScriptRunner#reportHealthStatus