[YARN-2988] Graph#save() may leak file descriptors

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.7.0
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 23/Dec/14 20:32
• Updated: 10/Apr/15 20:09
• Resolved: 25/Dec/14 04:52

Description

In hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/state/Graph.java :

  public void save(String filepath) throws IOException {
    OutputStreamWriter fout = new OutputStreamWriter(
        new FileOutputStream(filepath), Charset.forName("UTF-8"));
    fout.write(generateGraphViz());
    fout.close();

The close of fout should be enclosed in finally clause.