[XALANJ-2301] NPE in ElemTemplateElement for a ElemSort as part of an ElemForEach when dynamically generating a Templates - ASF JIRA

Agile Board

Attach files

Attach Screenshot

Add vote

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: 2.7
Fix Version/s: None
Component/s: None
Labels:
None

Xalan info:

PatchAvailable

Description

The XSL fragment that created this is:

<xsl:apply-templates select="something>
<xsl:sort select="@something"/>
</xsl:apply-templates>

resulting in:

java.lang.NullPointerException
at org.apache.xalan.templates.ElemTemplateElement.getStylesheetRoot(ElemTemplateElement.java:171)
at org.apache.xalan.templates.ElemTemplateElement.resolvePrefixTables(ElemTemplateElement.java:1033)
at org.apache.xalan.templates.ElemTemplateElement.compose(ElemTemplateElement.java:190)
at org.apache.xalan.templates.ElemSort.compose(ElemSort.java:333)
at org.apache.xalan.templates.ElemForEach.compose(ElemForEach.java:136)
at org.apache.xalan.templates.ElemCallTemplate.compose(ElemCallTemplate.java:113)
at org.apache.xalan.templates.ElemApplyTemplates.compose(ElemApplyTemplates.java:127)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:357)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:362)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:362)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:362)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:362)
at org.apache.xalan.templates.StylesheetRoot.composeTemplates(StylesheetRoot.java:362)
at org.apache.xalan.templates.StylesheetRoot.recompose(StylesheetRoot.java:337)
at org.apache.xalan.processor.StylesheetHandler.endDocument(StylesheetHandler.java:468)
... then enters my code

... this occurs because the ElemSort has a single entry in its m_declaredPrefixes vector, an entry for 'xsl'.

A 1-line fix to ElemForEach.java fixes this. In appendChild, when adding a sort element, just add:

newChild.setParentElem( this );

before returning the newChild.