[WW-4514] DefaultUrlHelper.buildParametersString appends just ? if collection is empty

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.3.24
• Fix Version/s: 6.1.1
• Component/s: Core Actions
• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Jasper Rosenberg
• Created: 12/Jun/15 13:34
• Updated: 26/Jan/23 12:26
• Resolved: 06/Nov/22 08:59

Description

DefaultUrlHelper.buildParametersString() checks that it has parameters to append before adding the first "?"/"&", but if the only parameters are empty Iterables/Arrays, then it shouldn't do that.

I'd suggest adding the new query string to a StringBuilder, and then if it is non-empty, append that with the separator to the link at the end. (See patch)

Issue Links

• links to: GitHub Pull Request #630