Issue Details (XML | Word | Printable)

Key: WODEN-167
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: John Kaputin
Reporter: John Kaputin
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Woden

OMWSDLReader mismatch with DOMWSDLFactory

Created: 10/Jul/07 10:45 PM   Updated: 02/Aug/07 01:57 PM
Return to search
Component/s: Parser
Affects Version/s: None
Fix Version/s: M8

Time Tracking:
Not Specified

Resolution Date: 02/Aug/07 01:57 PM


 Description  « Hide
WSDLReader impl classes should be used with the corresponding WSDLFactory subclass...OM to OM, DOM to DOM. If OMWSDLReader.getFactory() is called and no factory object or factory impl class name is stored in OMWSDLReader, the WSDLFactory.newInstance() default is to return a DOMWSDLFactory. The solution is to either set the correct factory impl class name on the OMWSDLReader object or better still, store the factory object that was used to instantiate the reader. The factory should pass a reference to itself to the reader object it creates.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
John Kaputin added a comment - 10/Jul/07 10:54 PM
The ctors for BaseWSDLReader, DOMWSDLReader and OMWSDLReader have been changed from no arg ctors to single arg ctors that take a WSDLFactory object. This is stored in BaseWSDLReader. DOMWSDLFactory passes 'this' to the DOMWSDLReader ctor and likewise for OMWSDLFactory and OMWSDLReader.

Using the Woden API, reader objects should only be created via the newWSDLReader() method of the corresponding factory. Therefore, the access modifiers for these ctors have been changed to default (package private) to enforce the programming model.

John Kaputin added a comment - 10/Jul/07 11:06 PM
r555107
BaseWSDLReader
DOMWSDLFactory
DOMWSDLReader
OMWSDLFactory
OMWSDLReader

John Kaputin added a comment - 02/Aug/07 01:57 PM
Fixed.