Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-3781

Differentiate Google Chrome from Safari in wicket-xyz.js

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.5-RC4
    • 1.5-RC5
    • wicket
    • None

    Description

      Currently Google Chrome is treated as Safari in wicket-ajax.js and wicket-event.js.
      This causes Wicket.replaceOuterHtmlSafari() to be used while Chrome supports Range and ContextualFragment like Gecko browsers.
      The special code in replaceOuterHtmlSafari() is for older versions of Safari but it is hard to test, so improvements in this area for Safari 5 will be done when Wicket Ajax starts use some JS library.

      This change is a bit risky because until now Chrome was treated as Safari and we all tested this behavior but I tested all Ajax examples in wicket-examples and my application and everything seems to be OK.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            mgrigorov Martin Tzvetanov Grigorov
            mgrigorov Martin Tzvetanov Grigorov
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment