Properly decode URLs

• Key: WICKET-358
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Jean-Baptiste Quenot
• Reporter: Jean-Baptiste Quenot
• Component/s: wicket
• Fix Version/s: 1.3.0-beta1, 2.0 branch (discontinued)

Description

There are places where Wicket decodes an URL and builds a Map of parameters:
* Form.FormDispatchRequest(Request, String)
* WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
* MockHttpServletRequest
* AutoLinkResolver
* PageParameters(String, String)
* CryptedUrlWebRequestCodingStrategy

Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.

Comments

[Jean-Baptiste Quenot]

Also change CryptedUrlWebRequestCodingStrategy, and deprecate PageParameters(String, String) which is meant to be used for decoding URL parameters.

[Jean-Baptiste Quenot]

Handle empty values correctly

[Johan Compagner]

what about BookmarkablePageRequestTargetUrlCodingStrategy.appendParameters(AppendingStringBuffer url, Map parameters)
where we call String escapedValue = urlEncode(entry.getValue().toString()); (also done in QueryStringUrlCodingStrategy)

[Jean-Baptiste Quenot]

Johan: this issue is only about decoding an URL into a ValueMap. But thanks for pointing me to BookmarkablePageRequestTargetUrlCodingStrategy, actually there is yet another decoding method in AbstractRequestTargetUrlCodingStrategy.decodeParameters(String, Map) that uses slashes instead of ampersand and equal signs. However it seems to properly handle URL decoding and String arrays, and because of the slashes it is too specific to merge it with another existing method.

[Jean-Baptiste Quenot]

Done in 1.x, need to port to trunk