Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-2598

Some components still escape non-ASCII symbols by default

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.4.3
    • 1.4.5, 1.5-M1
    • wicket
    • None

    Description

      With fix for WICKET-1054 Wicket (almost) stopped escaping non-ASCII symbols by default, it calls Strings.escapeMarkup(String) or Strings.escapeMarkup(String, false, false).

      However, there are still some places that also call Strings.escapeMarkup with different args.

      I used "Strings.escapeMarkup(.*, false, true)" regex to find them:
      AbstractChoice.escapeOptionHtml,
      CheckBoxMultipleChoice.onComponentTagBody (the reason i started to dig into this issue)
      RadioChoice.onComponentTagBody

      They should either call String.escapeMarkup(String) or even use Component.getDefaultModelObjectAsString

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. WICKET-1900 Implement isEscapeLabalMarkup for RadioChoice

          • Major - Major loss of function.
          • Closed

          Activity

            People

              jdonnerstag Juegen Donnerstag
              slonopotamus Marat Radchenko
              Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: