[WICKET-2184] Check component id against invalid chars ':' and empty IDs

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4-RC2
• Fix Version/s: 1.4-RC3
• Component/s: wicket
• Assignee: Juegen Donnerstag
• Reporter: Juegen Donnerstag
• Created: 21/Mar/09 10:25
• Updated: 12/Apr/09 21:22
• Resolved: 12/Apr/09 21:22

Description

Currently we are only testing a component id not to be null. However ':' and empty Ids are effectively invalid as well.

Component.java coiuld be modified as follows:
final void setId(final String id)
{
if (!(this instanceof Page))
{
if (Strings.isEmpty(id))

{ throw new WicketRuntimeException("Null or empty component ID's are not allowed."); }

if (id.indexOf(':') != -1)

{ throw new WicketRuntimeException("The component ID must not contain ':' chars."); }

}
this.id = id;
}