Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-193

IndexedParamUrlCodingStrategy does not decode PageParameters

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0 branch (discontinued), 1.3.0-beta1
    • None
    • None
    • all

    Description

      i noticed that wicket encodes all PageParameters for a page using the IndexedParamUrlCodingStrategy, but never decodes it, so you get the input raw, wich is opposite of the behaviour of BookmarkablePageRequestTargetUrlCodingStrategy where all parameters are encoded and decoded completely - this give great problems in developement as well as the lock to a single strategy in bigger projects as you would need to manually fix it every time you switch.

      Furthermore: "We should look at the complete encode/decode story anyway. Now it is done in numerous places some like String.replace("&", "&") and here a decode there a encode. This should all be done for the complete url itself i think in one place (instead per parameter or value)" - JCompagner

      Attachments

        Issue Links

          Activity

            People

              jbq Jean-Baptiste Quenot
              korbinian Korbinian Bachl
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: