Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-151

set session locale when constructing session object

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0 branch (discontinued), 1.3.0-beta1
    • wicket
    • None

    Description

      Currently, we create the session objects like this:

      WebApplication#getSession:

      if (session == null)
      {
      // Create session using session factory
      session = getSessionFactory().newSession(request);
      // Set the client Locale for this session
      session.setLocale(request.getLocale());

      What I propose is to change the constructor from Session/ WebSession to take in a Locale parameter as well. That would make it possible for custom session classes to fix the locale by setting it in the constructor. Now that is only possible by overriding Session#getLocale

      Attachments

        Activity

          People

            ehillenius Eelco Hillenius
            ehillenius Eelco Hillenius
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: