[WICKET-1383] MiniMap IndexOutOfBoundsException when empty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.1
• Fix Version/s: 1.3.2
• Component/s: wicket
• Assignee: Igor Vaynberg
• Reporter: John Patterson
• Created: 29/Feb/08 09:10
• Updated: 08/Mar/08 20:45
• Resolved: 08/Mar/08 20:45

Description

findKey() assumes that there is at least one entry in the map

This checks first:

Index: /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/collections/MiniMap.java
===================================================================
— /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/collections/MiniMap.java (revision 614519)
+++ /Users/John/Development/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/util/collections/MiniMap.java (working copy)
@@ -118,13 +118,16 @@
*/
public Object get(final Object key)
{

• // Search for key
• final int index = findKey(key);
  -
• if (index != -1)
  + if (size > 0)
  {
• // Return value
• return values[index];
  + // Search for key
  + final int index = findKey(key);
  +
  + if (index != -1)
  + { + // Return value + return values[index]; + }

  }

// Failed to find key