[WICKET-108] onDetach in HtmlHeaderContainer isn't being called -> java.io.NotSerializableException: wicket.response.StringResponse

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0-beta1
• Fix Version/s: 2.0 branch (discontinued), 1.3.0-beta1
• Assignee: Unassigned
• Reporter: Alastair Maw
• Created: 24/Nov/06 17:04
• Updated: 25/Nov/06 23:20
• Resolved: 25/Nov/06 23:20

Description

Am rudely assigning this one to Eelco without consultation, as I think he broke it.

HtmlHeaderContainer is keeping its reference to headerResponse, which isn't serializable, causing a java.io.NotSerializableException: wicket.response.StringResponse.

It should be throwing away the reference on #onDetach(). For some reason #onDetach() isn't being called when presumably it should be. I'm still getting up to speed with how all this stuff works, so hopefully you'll be able to chase this one more efficiently than I can.

In case it's useful, the stack trace for creating the HtmlHeaderContainer is something like this:
HtmlHeaderResolver.resolve(MarkupContainer, MarkupStream, ComponentTag) line: 79
MyRandomPage(MarkupContainer).renderNext(MarkupStream) line: 1359
MyRandomPage(MarkupContainer).renderAll(MarkupStream) line: 942
MyRandomPage(Page).onRender(MarkupStream) line: 978
MyRandomPage(Component).render(MarkupStream) line: 1521
MyRandomPage(Page).renderPage() line: 413
BookmarkablePageRequestTarget.respond(RequestCycle) line: 226
DefaultResponseStrategy.respond(RequestCycle) line: 47