[VALIDATOR-492] ValidatorUtils.copyFastHashMap is broken

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.8.0
• Fix Version/s: 1.9.0
• Assignee: Unassigned
• Reporter: Tobias Wildgruber
• Created: 20/Feb/24 14:51
• Updated: 21/Mar/24 02:40
• Resolved: 21/Mar/24 02:40

Description

ValidatorUtils.copyFastHashMap is broken which in turn causes Field#clone() to loose hVars and hMsgs. Field#clone().

This is f.e. used in ValidatorAction#
handleIndexedField() causing validation to misbehave when using indexedListProperty (which is where we found this).
Test case that fails in 1.8.0 but works in 1.7:

public void testCopyFastHashMap() {
  final FastHashMap original = new FastHashMap();
  original.put("key1", "value1");
  original.put("key2", "value2");
  original.put("key3", "value3");
  original.setFast(true);
  final FastHashMap copy = ValidatorUtils.copyFastHashMap(original);
  assertEquals(original, copy);
}