[VALIDATOR-468] DomainValidator.getTLDArray does not synch mutable arrays

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7
• Assignee: Unassigned
• Reporter: Sebb
• Created: 21/Jun/20 13:22
• Updated: 08/Aug/20 11:55
• Resolved: 21/Jun/20 16:27

Description

The method DomainValidator.getTLDEntries is currently unsynchronized.

This means that there may be issues with the contents of the mutable override arrays.
Although the arrays are marked volatile, that does not protect the array entries.

Note: although #isValid() is not synchronised, this can only be used after calling a synchronised getInstance.

AFAICT there is no point in leaving the arrays volatile.