[VALIDATOR-387] Userinfo without colon should be valid in UrlValidator

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.6
• Assignee: Unassigned
• Reporter: Shumpei Akai
• Created: 28/Jan/16 06:59
• Updated: 04/Feb/18 13:46
• Resolved: 05/Feb/17 18:35

Description

UrlValidator does not accept userinfo without ":".
The following code returns false.

UrlValidator validator = new UrlValidator();
validator.isValid("http://[e-mail]:80/path")

But it should be accepted.

RFC of URI allows userinfo without colon.
https://tools.ietf.org/html/rfc3986#section-3.2.1

userinfo = *( unreserved / pct-encoded / sub-delims / ":" )

RFC of URL also allows it.
https://tools.ietf.org/html/rfc1738#section-3.1

//<user>:<password>@<host>:<port>/<url-path>
Some or all of the parts "<user>:<password>@", ":<password>",
":<port>", and "/<url-path>" may be excluded.

I created Pull Request.
https://github.com/apache/commons-validator/pull/5

Issue Links

• links to: GitHub Pull Request #5