Lodaing of Digester Rules for classes extending ValidatorResources does not work

• Key: VALIDATOR-195
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Niall Pemberton
• Reporter: Vijay Pandey
• Component/s: Framework
• Affects Version/s: 1.2.0 Release, 1.3.0 Release
• Fix Version/s: 1.3.1 Release

Description

If we extend the class "ValidatorResources", then the loading of the digester rules does not work properly.

--------------------------------ValidatorResources--------------------------------------------------------
private Digester initDigester() {
URL rulesUrl = this.getClass().getResource("digester-rules.xml");
-----------------------------------------------------------------------------------------------------------------------
The above line tries to find the "digester-rules.xml" from the path of extending class and hence to make this work we need to
copy the digester rules xml file in the same pacakge as the extending class.

I think a better way might be is to accept a InputStream or URL for the digester rules in the constructor if someone wants to
have their custom digester rules, and by default if it's not provided it should always take from the ValidatorResources path
by changing the code

this.getClass().getResource("digester-rules.xml");

to

ValidatorResources.class.getResource("digester-rules.xml");

Thanks
Vijay

Comments

[Niall Pemberton]

Changing ValidatorResources to always load the digester rules from the "org.apache.commons.validator" package could break behaviour for someone relying on this (i.e. if they're plugging in their own custom Digester rules) - so I don't want to make the change you requested.

I have however modified ValidatorResources to use the digester rules in the "org.apache.commons.validator" package if no rules are found in the default package for the class - this should resolve your issue and retain backwards compatibility:

http://svn.apache.org/viewvc?view=rev&revision=478392

Thanks for reporting this

Niall