[UIMA-5877] UIMA-DUCC: Pull service not failing fast on initialization error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.0.0-Ducc
• Component/s: DUCC
• Assignee: Jaroslaw Cwiklik
• Reporter: Jaroslaw Cwiklik
• Created: 01/Oct/18 20:05
• Updated: 08/Oct/18 17:48
• Resolved: 08/Oct/18 17:48

Description

With multiple threads initializing, the protocol handler serializes call to processor.initialize() so that only one thread is allowed to initialize at a time.

If initialization fails the design goal is for the remaining threads to fail-fast if a previous thread failed. The check for error was in the wrong place in the DefaultServiceProtocolHandler.initialize(). Modify to do the check after a thread acquires a lock as in the below snippet:

try {
    // use a lock to serialize initialization one thread at a time
    initLock.lock();
    if (initError)

{         return;     }

    processor.initialize();

...