[TS-5012] CID 1267812 Logically Dead Code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.1.0
• Component/s: Manager
• Labels: coverity
• Assignee: Nathan Garabedian
• Reporter: Nathan Garabedian
• Created: 27/Oct/16 00:01
• Updated: 27/Oct/16 08:32
• Resolved: 27/Oct/16 08:32

Description

8void
189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
190{
191 int idx;
192
cond_at_least: Condition id != 0U, taking true branch. Now the value of id is at least 1.
cond_cannot_single: Condition id != 0U, taking true branch. Now the value of id cannot be equal to 0.
193 ink_assert(id != 0);
cond_between: Condition id <= 100U, taking true branch. Now the value of id is between 1 and 100.
194 ink_assert(id <= MAX_CONFIGS);
195
between: At condition id == 0U, the value of id must be between 1 and 100.
cannot_single: At condition id == 0U, the value of id cannot be equal to 0.
dead_error_condition: The condition id == 0U cannot be true.
cond_between: Condition id == 0U, taking false branch. Now the value of id is between 1 and 100.
between: At condition id > 100U, the value of id must be between 1 and 100.
cannot_single: At condition id > 100U, the value of id cannot be equal to 0.
dead_error_condition: The condition id > 100U cannot be true.
196 if (id == 0 || id > MAX_CONFIGS)

{ 197 // nothing to delete since we have an invalid index CID 1267812 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: return;. 198 return; 199 }

200

Issue Links

• links to: GitHub Pull Request #1155