[TS-4864] CID 1362769: Control flow issues (DEADCODE) in ink_thread.h

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.1.0
• Component/s: Core
• Labels: Coverity
• Assignee: Nathan Garabedian
• Reporter: Leif Hedstrom
• Created: 14/Sep/16 01:59
• Updated: 15/Sep/16 23:33
• Resolved: 15/Sep/16 23:33

Description

Filing this just in case, but maybe Nathan's fixes around this is where to go ?

*** CID 1362769:  Control flow issues  (DEADCODE)
/lib/ts/ink_thread.h: 160 in ink_thread_create(void *(*)(void *), void *, int, unsigned long, void *)()
154       pthread_attr_destroy(&attr);
155     
156       /**
157        * Fix for INKqa10118.
158        * If the thread has not been created successfully return 0.
159        */
   CID 1362769:  Control flow issues  (DEADCODE)
   Execution cannot reach the expression "0UL" inside this statement: "return ret ? 0UL : t;".
160       return ret ? (ink_thread)0 : t;
161     }
162     
163     static inline void
164     ink_thread_cancel(ink_thread who)
165     {

Issue Links

• links to: GitHub Pull Request #1021