[TS-2528] better bool handling in public APIs (ts / mgmt)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0.0
• Component/s: Management API
• Labels: api-change
• Assignee: Leif Hedstrom
• Reporter: Zhao Yongming
• Created: 24/Jan/14 09:32
• Updated: 18/Dec/14 05:11
• Resolved: 24/May/14 00:47

Description

  tsapi bool TSListIsEmpty(TSList l);
  tsapi bool TSListIsValid(TSList l);
  tsapi bool TSIpAddrListIsEmpty(TSIpAddrList ip_addrl);
  tsapi bool TSIpAddrListIsValid(TSIpAddrList ip_addrl);
  tsapi bool TSPortListIsEmpty(TSPortList portl);
  tsapi bool TSPortListIsValid(TSPortList portl);
  tsapi bool TSStringListIsEmpty(TSStringList strl);
  tsapi bool TSStringListIsValid(TSStringList strl);
  tsapi bool TSIntListIsEmpty(TSIntList intl);
  tsapi bool TSIntListIsValid(TSIntList intl, int min, int max);
  tsapi bool TSDomainListIsEmpty(TSDomainList domainl);
  tsapi bool TSDomainListIsValid(TSDomainList domainl);
  tsapi TSError TSRestart(bool cluster);
  tsapi TSError TSBounce(bool cluster);
  tsapi TSError TSStatsReset(bool cluster, const char *name = NULL);
  tsapi TSError TSEventIsActive(char *event_name, bool * is_current);

and we have:

#if !defined(linux)
#if defined (__SUNPRO_CC) || (defined (__GNUC__) || ! defined(__cplusplus))
#if !defined (bool)
#if !defined(darwin) && !defined(freebsd) && !defined(solaris)
// XXX: What other platforms are there?
#define bool int
#endif
#endif

#if !defined (true)
#define true 1
#endif

#if !defined (false)
#define false 0
#endif

#endif
#endif  // not linux

I'd like we can make it a typedef or replace bool with int completely, to make things better to be parsed by SWIG tools etc.