[#TRB-16] TurbineURI mishandles the empty String

Turbine

TurbineURI mishandles the empty String

Created: 22/Jun/06 09:01 PM Updated: 06/Jan/09 09:06 PM

Return to search

Component/s:

Turbine 2.3

Affects Version/s:

Core 2.3.2

Fix Version/s:

None

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
patch-TRB-16-t2.4.txt	2006-06-23 05:00 AM	Jürgen Hoffmann	1 kB
patch-TRB-16.txt	2006-06-22 09:09 PM	Jürgen Hoffmann	6 kB

Resolution Date:

23/Jun/06 01:18 PM

Description

« Hide

If you pass a value of "" TurbineURI adds the value "null" instead. This makes it hard to evaluate the passed value, and which is definetly unwanted behaviour.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Jürgen Hoffmann added a comment - 22/Jun/06 09:09 PM

added a fix and tests for correct handling of empty values in the future.

Jürgen Hoffmann made changes - 22/Jun/06 09:09 PM

Field	Original Value	New Value
Attachment		patch-TRB-16.txt [ 12335777 ]

[ Permlink | « Hide ]

Jürgen Hoffmann added a comment - 23/Jun/06 05:00 AM

This patch fixes current Turbine Trunk which has the same problem.

Jürgen Hoffmann made changes - 23/Jun/06 05:00 AM

Attachment

patch-TRB-16-t2.4.txt [ 12335801 ]

[ Permlink | « Hide ]

Jürgen Hoffmann added a comment - 23/Jun/06 05:01 AM

By the way the problematic file is TurbineURI not TemplateURI sorry.

Repository	Revision	Date	User	Message
ASF	#416581	Fri Jun 23 06:17:12 UTC 2006	seade	~~TRB-16~~: TurbineURI mishandles the empty String Thanks to Juergen Hoffmann inspiring this patch.
				Files Changed
				MODIFY /jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/java/org/apache/turbine/util/uri/TurbineURI.java MODIFY /jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/xdocs/changes.xml MODIFY /jakarta/turbine/core/branches/TURBINE_2_3_BRANCH/src/test/org/apache/turbine/util/uri/TurbineURITest.java

Repository	Revision	Date	User	Message
ASF	#416582	Fri Jun 23 06:17:34 UTC 2006	seade	~~TRB-16~~: TurbineURI mishandles the empty String Thanks to Juergen Hoffmann inspiring this patch.
				Files Changed
				MODIFY /jakarta/turbine/core/trunk/xdocs/changes.xml MODIFY /jakarta/turbine/core/trunk/src/test/org/apache/turbine/util/uri/TurbineURITest.java MODIFY /jakarta/turbine/core/trunk/src/java/org/apache/turbine/util/uri/TurbineURI.java

[ Permlink | « Hide ]

Scott Eade added a comment - 23/Jun/06 01:18 PM

The existing behaviour for "null" is retained - after all null != "".
An empty String is now retained as such.
Thanks for your patch.

Scott Eade made changes - 23/Jun/06 01:18 PM

Assignee		Scott Eade [ seade ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

Scott Eade made changes - 23/Jun/06 01:30 PM

Summary

TemplateURI mishandles the empty String

TurbineURI mishandles the empty String

[ Permlink | « Hide ]

Scott Eade added a comment - 23/Jun/06 01:31 PM

Corrected the title and description so as to avoid confusion.

Scott Eade made changes - 23/Jun/06 01:31 PM

Description

If you pass a value of "" TemplateURI adds the value "null" instead. This makes it hard to evaluate the passed value, and which is definetly unwanted behaviour.

If you pass a value of "" TurbineURI adds the value "null" instead. This makes it hard to evaluate the passed value, and which is definetly unwanted behaviour.

[ Permlink | « Hide ]

Thomas Vandahl added a comment - 06/Jan/09 09:06 PM

Fix is in 2.3.3-release

Thomas Vandahl made changes - 06/Jan/09 09:06 PM

Status

Resolved [ 5 ]

Closed [ 6 ]