[TORQUE-89] OrderByColumn for COUNT, SUM

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3-RC2
• Fix Version/s: 4.0-beta1
• Component/s: Runtime
• Environment: Linux
• Assignee: Thomas Fox
• Reporter: Stefan Birrer
• Created: 15/Apr/07 10:03
• Updated: 24/Sep/12 07:06
• Resolved: 30/Jan/12 18:21

Description

I've a "complicated" JOIN statement that features some custom column like "COUNT(a) AS ca".

Torque runtime fails on the

Criteria::addAscendingOrderByColumn("ca")

because it expects a full qualified table.columnName which is not the case for the example "ca" column.

The problem can be fixed by adapting the following functions (3.3-RC2):
src/java/org/apache/torque/util/SQLBuilder.java
removeSQLFunction(final String name) : name must not necessarily contain '.' or '*" thus replacing the first thrown exception with a "return name" fixes that issue
processOrderBy(...) : in the for loop, strippedColumnName must not contain '.' hence replacing the first thrown exception with "orderByColumn.add(orderByColumn); break;" fixes the issue

This are quick fixes and I guess you want to reconsider whether you want to implement it that way. After these two changes, it was working correctly though.