[TORQUE-42] Criteria.andDate missing getTime() method call

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2
• Fix Version/s: 3.3
• Component/s: Runtime
• Environment: java5, tomcat 5.5.17
• Assignee: Thomas Vandahl
• Reporter: Federico Fissore
• Created: 12/Jul/06 18:29
• Updated: 26/Nov/06 18:23
• Resolved: 14/Jul/06 03:59

Description

Hello all,

there is a bug in Criteria.andDate: the call to the method getTime() is missing while it is present in Criteria.addDate

To exploit it use a code like

calendar.setTime(new Date());
crit.addDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH), calendar.get(Calendar.DAY_OF_MONTH), Criteria.GREATER_EQUAL);

calendar.add(Calendar.DAY_OF_MONTH, 1);
crit.andDate(GpsLocationPeer.LAST_UPDATE, calendar.get(Calendar.YEAR), calendar.get(Calendar.MONTH), calendar.get(Calendar.DAY_OF_MONTH), Criteria.LESS_THAN);

This leads to a SQLException due to incorrect sql query creation.
That is easy to see with Criteria.toString()

Adding the missing method call solves the problem

Please, check the attached patch. Thank you