[TIKA-3081] TikaInputStream's skip() should use the equivalent of IOUtils.skipFully()

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.24.1
• Assignee: Unassigned
• Reporter: Tim Allison
• Created: 01/Apr/20 16:00
• Updated: 21/Apr/20 18:54
• Resolved: 21/Apr/20 18:54

Description

Some parsers may assume that skip() returns the number of bytes actually skipped. As we've learned, FileInputStream's return value can be completely divorced from reality, and it can report that the stream is skipping even past the EOF.

If we convert TikaInputStream's skip() to something that will throw an exception if a 3rd party parser tries to skip past the end of a file, we may prevent an entire class of bugs.