[TIKA-1620] OUTPUT_FILE_TOKEN not being replaced in ExternalParser

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7, 1.8
• Fix Version/s: 1.9
• Component/s: parser

Environment

Any.

• Assignee: Unassigned
• Reporter: Pascal Essiembre
• Created: 30/Apr/15 19:41
• Updated: 07/May/15 18:44
• Resolved: 07/May/15 01:24

Description

According to class documentation, the org.apache.tika.parser.external.ExternalParser class should replace the OUTPUT_FILE_TOKEN constant with an output file name when specified as a command argument. It is currently not the case and the parser will fail to grab any output from processes generating output files.

In order to fix this, you should add one line to the following code in the parse method (starting on line 168):

if(cmd[i].indexOf(OUTPUT_FILE_TOKEN) != -1) {
    output = tmp.createTemporaryFile();
    outputFromStdOut = false;
    //START FIX:
    cmd[i] = cmd[i].replace(OUTPUT_FILE_TOKEN, output.getPath());
    //END FIX.
}

Issue Links

• is blocked by: TIKA-634 Command Line Parser for Metadata Extraction