Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-565

Structs containing typedefs for incomparable objects will be considered comparable

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.2
    • 0.2
    • Java - Compiler
    • None

    Description

      The is_comparable method in the Java code generator doesn't resolve typedefs. This means that if you typedef a map or set, for instance, structs including fields of that typedef will be considered comparable even though they should not be.

      Attachments

        1. thrift-565.patch
          0.9 kB
          Bryan Duxbury
        2. thrift-565-v2.patch
          3 kB
          Bryan Duxbury

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bryanduxbury Bryan Duxbury
            bryanduxbury Bryan Duxbury
            Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment