[THRIFT-4192] Generated java async code generates a result structure that is unused (Coverity)

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Duplicate
• Affects Version/s: 0.10.0
• Component/s: Java - Compiler
• Assignee: James E. King III
• Reporter: James E. King III
• Created: 08/May/17 13:03
• Updated: 14/Jun/17 14:36
• Resolved: 14/Jun/17 14:36

Description

The async method generator for Java emits an onError handler which contains this pattern:

         public void onError(java.lang.Exception e) {
1556            byte msgType = org.apache.thrift.protocol.TMessageType.REPLY;
1557            org.apache.thrift.TSerializable msg;
    CID 26029 (#1 of 1): DLS: Dead local store (FB.DLS_DEAD_LOCAL_STORE)1. defect: Dead store to result.
1558            Delete_Bundle_Request_Data_result result = new Delete_Bundle_Request_Data_result();
1559            if (e instanceof org.apache.thrift.transport.TTransportException) {
1560              _LOGGER.error("TTransportException inside handler", e);
1561              fb.close();
1562              return;
1563            } else if (e instanceof org.apache.thrift.TApplicationException) {

The item on line 1558 is not used. Any call method in a service definition will cause this.

Issue Links

• duplicates: THRIFT-4228 Generated java service code emits a few dead local stores