[TEZ-4432] Remove useless maybeAddDefaultLoggingJavaOpts from TezClientUtils

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.3
• Assignee: Ayush Saxena
• Reporter: László Bodor
• Created: 04/Jul/22 08:34
• Updated: 23/Jun/23 15:13
• Resolved: 23/Jun/23 15:13

Description

After TEZ-3918, which removed most of the method body, only a null check can be found.

  static void maybeAddDefaultLoggingJavaOpts(String logLevel, List<String> vargs) {
    Objects.requireNonNull(vargs);
    TezClientUtils.addLog4jSystemProperties(logLevel, vargs);
  }

I believe this method should be removed and Objects.requireNonNull should be moved to addLog4jSystemProperties

Issue Links

• is related to: TEZ-3918 Setting tez.task.log.level does not work
• links to: GitHub Pull Request #297