Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-422

ExternalService.getLink javadoc needs to inform that the returned URL is encoded

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 4.0, 3.0.5
    • 4.0.1, 3.0.5
    • Documentation
    • None

    Description

      This may apply to other services as well.
      The ExternalService.getLink javadoc was copied from IEngineService.getLink javadoc.
      It states that "Returns: The URL for the service. The URL will have to be encoded via HttpServletResponse.encodeURL(java.lang.String)."
      However, looking at the source code, this is NOT the case for ExternalService's links. They are always encoded.

      Attachments

        1. TAPESTRY-422-branch-3.0.patch
          1 kB
          Brian K. Wallace
        2. TAPESTRY-422-trunk.patch
          0.9 kB
          Brian K. Wallace

        Activity

          People

            jkuhnert Jesse Kuhnert
            andyhot Andreas Andreou
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: