LinkSubmit can cause browser back button problems

• Key: TAPESTRY-339
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Jesse Kuhnert
• Reporter: Nick Westgate
• Affects Version/s: 3.0.5
• Fix Version/s: 3.0.5

Description

If LinkSubmit is mixed with other submit components in the same form, erroneous submits can occur from pages accessed via the browser back button. This happens because LinkSubmit's hidden variable is never reset.

Suggested fix (line marked +++) in LinkSubmit.java, renderComponent method:

                // make sure the submit function is on the page (once)
                if (cycle.getAttribute(ATTRIBUTE_FUNCTION_NAME) == null)
                {
+++ body.addInitializationScript("document." + formName + "._linkSubmit.value = null;");
                    body.addBodyScript(
                        "function submitLink(form, elementId) { form._linkSubmit.value = elementId; if (form.onsubmit == null || form.onsubmit()) form.submit(); }");
                    cycle.setAttribute(ATTRIBUTE_FUNCTION_NAME, this);
                }

It would be great if the corrected LinkSubmit submission mechanism detail was factored out into a separate class, so that other submit components could be built using it. For example, Glen Stampoultzis's ButtonSubmit component.

Comments

[Nick Westgate]

Oops. Damn Mondays ... the line (+++) should go in this block:

                // one hidden field per form:
                String formHiddenFieldAttributeName = ATTRIBUTE_FUNCTION_NAME + formName;
                if (cycle.getAttribute(formHiddenFieldAttributeName) == null)
                {
+++ body.addInitializationScript("document." + formName + "._linkSubmit.value = null;");
                    writer.beginEmpty("input");
                    writer.attribute("type", "hidden");
                    writer.attribute("name", "_linkSubmit");
                    cycle.setAttribute(formHiddenFieldAttributeName, this);
                }

[Jesse Kuhnert]

Applied to 3.0.4