[TAJO-1506] WorkerConnectionInfo::id field may be not unique, but its uniqueness is assumed throughout codes.

• Type: Improvement
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Component/s: QueryMaster, Worker
• Assignee: Jihun Kang
• Reporter: Hyunsik Choi
• Created: 02/Apr/15 02:04
• Updated: 02/Nov/15 20:23

Description

WorkerConnectionInfo::id is a integer value. It is generated in Worker by a hashCode as follows:

public WorkerConnectionInfo(String host, int peerRpcPort, int pullServerPort, int clientPort,
                              int queryMasterPort, int httpInfoPort) {
...
    this.queryMasterPort = queryMasterPort;
    this.httpInfoPort = httpInfoPort;
    this.id = hashCode();

Fundamentally, it uses hashCode method, so there are possibility to cause duplicate integer value. But, all codes assume its uniqueness. It is a potential problem.