[STORM-3702] Change thrift exception classes to contain getMessage() method

• Type: Improvement
• Status: In Progress
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.1.0
• Component/s: storm-client
• Assignee: Bipin Prasad
• Reporter: Bipin Prasad
• Created: 17/Sep/20 18:40
• Updated: 23/Sep/20 04:47

Description

Thrift classes are currently being generated without camel casing for method names. And the exception classes have a member variable called "msg". This generates, get_msg() and set_msg() method names. Since this class extends java Exception class, when an TException is thrown, the getMessage() method returns null and cannot be relied upon.

To get around this problem with getMessage() method, storm code has Wrapper classes, eg WrappedNotAliveException with a getMessage() method that return wraps get_msg() method in base class.

Proposed Change:

• Change the TException classes to rename member variable and generate camel cased class so that getMessage() is generated
• Limit the change to specific TException classes only to avoid large change
• Deprecate Wrapped classes