[STORM-2121] StringKeyValueScheme doesn't override getOutputFields() - ASF JIRA

Log work

Agile Board

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Add vote

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Open
Priority: Major
Resolution: Unresolved
Affects Version/s: None
Fix Version/s: None
Component/s: storm-kafka
Labels:
None

Description

In org.apache.storm.kafka StringKeyValueScheme extends StringScheme. However it doesn't override the method getOutputFields() from StringScheme

public Fields getOutputFields() {
        return new Fields(STRING_SCHEME_KEY);
    }

And this method returns only one field, instead of two (one for key and one for value), which causes problems.
It would be better to override the method getOutputFields() in StringKeyValueScheme with e.g.

    @Override
    public Fields getOutputFields() {
        return new Fields(FieldNameBasedTupleToKafkaMapper.BOLT_KEY, FieldNameBasedTupleToKafkaMapper.BOLT_MESSAGE);
    }

The important thing is, that getOutputFields() should return two fields and not one.