std::string::insert (iterator, InputIterator, InputIterator) inserting self incorrect

• Key: STDCXX-632
• Type: Bug
• Status: Reopened
• Priority: Minor
• Assignee: Unassigned
• Reporter: Farid Zaripov
• Component/s: 21. Strings
• Affects Version/s: 4.1.2, 4.1.3, 4.1.4, 4.2.0
• Fix Version/s: 4.3.0

Description

The 21.string.insert.cpp test has been failing a number of assertions for self-referential test cases that exercise the ability to insert a substring of a string into itself using the insert(iterator, InputIterator, InputIterator) member template specialization for InputIterator being an actual Input Iterator. The program below reproduces the problem in a small isolated test case.

#include <cassert>
#include <string>

int main ()
{
std::string s ("abc");

typedef const unsigned char UChar;
s.insert (s.begin (), (UChar*)&s [1], (UChar*)&s [2]);

assert ("babc" == s);
}

Comments

[Farid Zaripov]

Since string::insert() is implemented in terms of replace() resolving STDCXX-170 will also resolve this issue.

[Farid Zaripov]

Fixed in STDCXX-170.

Will be closed after adding the regression test for the issue.

[Farid Zaripov]

The STDCXX-170 issue is reverted and deferred to 4.3 release.
Deferring this issue too.

[Farid Zaripov]

The regression test added in trunk thus: http://svn.apache.org/viewvc?rev=637959&view=rev