Uploaded image for project: 'Sqoop (Retired)'
  1. Sqoop (Retired)
  2. SQOOP-2659

Sqoop2: Do not stop services that haven't been started in our integration test suite

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.99.6
    • 1.99.7
    • None
    • None

    Description

      While investigating pre-commit hook failures on SQOOP-2652 I was side tracked at a lot by seeing various exceptions from Hive and Kafka test cases with NullPointerException and spending time investigating them.

      Upon further investigation I've noticed that the whole reason is that we're shutting down something that wasn't started and hence the NPE. The problem was that my newly added test case had added an assume statement in @Before* family of methods. The assume statement return false and stopped test execution before the Hive/Kite test cases got initialized. However the testng will execute all tear down methods (@After* and not only those that have been initialized. Hence the tear down methods must be smart enough to not die if the initialization in fact did not happened.

      Attachments

        1. SQOOP-2659.patch
          3 kB
          Jarek Jarcec Cecho
        2. SQOOP-2659.patch
          3 kB
          Jarek Jarcec Cecho

        Issue Links

          Activity

            People

              jarcec Jarek Jarcec Cecho
              jarcec Jarek Jarcec Cecho
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: