[SPARK-3234] SPARK_HADOOP_VERSION and SPARK_HIVE depend on deprecated make-distribution.sh command line options - ASF JIRA

Rank to Top

Rank to Bottom

Attach files

Attach Screenshot

Bulk Copy Attachments

Bulk Move Attachments

Voters

Watch issue

Watchers

Create sub-task

Convert to sub-task

Link

Clone

Labels

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Bug
Status: Resolved
Priority: Minor
Resolution: Fixed
Affects Version/s: 1.0.2
Fix Version/s: 1.1.0
Component/s: Build
Labels:
None

Target Version/s:

1.2.0

Description

In make-distribution.sh, SPARK_HADOOP_VERSION is determined by --hadoop, and SPARK_HIVE is determined by --with-hive, but these two command line options are deprecated by `~~Dhadoop.version`/`-Phadoop~~??` and `-Phive` respectively. The result is that:

we may end up with something like spark-1.1.0-SNAPSHOT-bin-.tgz unless --name is specified explicitly
Datanucleus jars will not be included in the distribution folder/tarball unless we set SPARK_HIVE=true explicitly

A possible fix is to check hadoop.version and project.activeProfiles with mvn help:evaluate, similar to what we do now to determine VERSION.