[SOLR-9878] Code smell in if statement

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Fix Version/s: 6.4, 7.0
• Assignee: Unassigned
• Reporter: JC
• Created: 19/Dec/16 19:08
• Updated: 08/Jun/19 15:31
• Resolved: 21/Dec/16 12:04

Description

In recent code snapshot (Github mirror's commit id: c8542b2bd0470af9f8d64bb8133f31828b342604 as today), there is an illogical condition that can be a code smell or a potential bug:

ReversedWildcardFilterFactory fac = leadingWildcards.get(fieldType);
    if (fac != null || leadingWildcards.containsKey(fac)) {
      return fac;
    }

In SOLR-3492, it said there was a fix in SOLR-4093. However, the fix still has an issue as above: containsKey will always have null in this if statement. The second condition could be unnecessary. Does leadingWildcards allow a null object as a key? If so, it will return null that might cause NPE in some other locations.

Patch could be just like in SOLR-3492?:

if (fac != null)

Issue Links

• relates to: SOLR-7466 Allow optional leading wildcards in complexphrase