[SOLR-9740] Parameter substitution (MacroExpander) Map expand issue

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 6.0.1
• Fix Version/s: 6.4
• Assignee: Yonik Seeley
• Reporter: Erik Hatcher
• Created: 08/Nov/16 22:23
• Updated: 08/Jun/19 15:33
• Resolved: 08/Nov/16 23:13

Description

  @Test
  public void testMap() {
    final Map<String,String[]> request = new HashMap<String,String[]>();
    request.put("fq", new String[] {"${one_ref}","two"});
    request.put("one_ref",new String[] {"one"});
    Map expanded = MacroExpander.expand(request);
    assertEquals("one", ((String[])expanded.get("fq"))[0]);
    assertEquals("two", ((String[]) expanded.get("fq"))[1]);
  }

fails with `java.lang.ArrayIndexOutOfBoundsException` because the resultant `expanded` structure only has a single "fq" value of "one". "two" got eaten.