Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-970

SolrPluginUtils#parseQueryStrings(SolrQueryRequest) - replacing LinkedList with ArrayList for the internal impl of return type

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 1.4
    • None
    • None
    • Java 6, Tomcat 6

    Description

      Is there a specific reason to use LinkedList for the internal implementation of List<?> .

      ArrayList provides a better locality of reference than a LinkedList . Addition at the end of the list ( the default behavior of .add() ) is expensive for LinkedList again.

      Attachments

        1. SOLR-970.patch
          0.7 kB
          Karthik K

        Activity

          People

            hossman Chris M. Hostetter
            kaykay.unique Karthik K
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - 5m
                5m
                Remaining:
                Remaining Estimate - 5m
                5m
                Logged:
                Time Spent - Not Specified
                Not Specified