[SOLR-967] NamedList - Deprecating ctor. with heterogenous List and replacing with a type-safe variant.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.4

Environment

Java 6, Tomcat 6

• Assignee: Chris M. Hostetter
• Reporter: Karthik K
• Created: 19/Jan/09 17:31
• Updated: 10/Nov/09 15:51
• Resolved: 19/Feb/09 22:21

Description

NamedList (org/apache/solr/common/util/NamedList ) currently has a heterogenous List (even numbered indices are String-s ) and the odd-numbered indices are the specific types. As per benchmarks ( see SOLR-912 ) - the implementation could be improved in favor of a Map.Entry<String, T> that beats in performance and ease of code maintenance.

As per the discussion in SOLR-912 , a separate issue in JIRA is created that temporarily deprecates the List ctor. in NamedList and replaces the same with a Map.Entry<String, T> [] arg. constructor .

This would be go in 1.4 to enable people to migrate their code for the new ctor. and move away from List<?> .

At a later version of Solr (may be v2) - the optimal implementation would be brought back in with the List <Map.Entry<String, ?> > for better type-safety and performance.

Issue Links

• is related to: SOLR-912 org.apache.solr.common.util.NamedList - Typesafe efficient variant - ModernNamedList introduced - implementing the same API as NamedList